Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI5ElementMetadata: Bring back events in metadata #833

Closed
MarcusNotheis opened this issue Oct 10, 2019 · 2 comments · Fixed by #837
Closed

UI5ElementMetadata: Bring back events in metadata #833

MarcusNotheis opened this issue Oct 10, 2019 · 2 comments · Fixed by #837
Assignees

Comments

@MarcusNotheis
Copy link
Collaborator

Hi,

I saw that in the latest release (v1.0.0-rc.3), the merging of metadata events and the event getter was removed.

This change is breaking the Web Components for React wrapper because we are heavily relying in the events metadata.

Example

The Dialog has no events defined, because events like onBeforeClose are defined in the Popup.
As the events are not merged any longer, the dialog metadata is not containing any events.
--> our wrapper can't bind them because they are "invisible" for us

Is there a specific reason why this logic was removed and can you bring it back?

Thanks,
Marcus

@ilhan007
Copy link
Member

ilhan007 commented Oct 10, 2019

Hello @marcus,

no specific reason other than it was not used internally and we were
not aware that you depend on it, sorry for that, we will get the events info in the metadata.

Best,
ilhan

@MarcusNotheis
Copy link
Collaborator Author

perfect, thanks!
Do you already have an estimate when you want to release a version with events again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants