Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-color-picker): add missing hex value to RGBtoHEX method #9906

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

hinzzx
Copy link
Contributor

@hinzzx hinzzx commented Sep 19, 2024

There was a HEX value missing in the RGBtoHEX() method in the ColorConversion util.
With this change we added it.

Before

<div id="text"></div>

<script>
document.getElementById("text").innerHTML = RGBtoHEX({
  r: 207,
  b: 223,
  g: 255
});  // results in #CundefinedundefinedundefinedDundefined
</script>

After

<div id="text"></div>

<script>
document.getElementById("text").innerHTML = RGBtoHEX({
  r: 207,
  b: 223,
  g: 255
});  // results in #CFFFDF
</script>

Fixes: #9895

@hinzzx hinzzx marked this pull request as ready for review September 19, 2024 12:44
@hinzzx hinzzx merged commit 90acd68 into main Sep 19, 2024
10 checks passed
@hinzzx hinzzx deleted the cp-rgbtohex-util-fix branch September 19, 2024 12:52
nowakdaniel pushed a commit that referenced this pull request Sep 25, 2024
There was a HEX value missing in the `RGBtoHEX()` method in the ColorConversion util.
With this change we add it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColorConversion.js HEXtoRGB util does not work properly with some values
2 participants