From b81e4e16511a85508593fbccd2241eca5cdf1c9a Mon Sep 17 00:00:00 2001
From: codefactor <codefactor@users.noreply.github.com>
Date: Fri, 19 Nov 2021 18:17:37 -0800
Subject: [PATCH 1/3] fix: adding stable selectors for tab container and
 shellbar

---
 packages/fiori/src/ShellBar.hbs    | 5 ++++-
 packages/main/src/TabContainer.hbs | 3 +++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/packages/fiori/src/ShellBar.hbs b/packages/fiori/src/ShellBar.hbs
index f9a727e3cc25..e5cf2cc8b8ad 100644
--- a/packages/fiori/src/ShellBar.hbs
+++ b/packages/fiori/src/ShellBar.hbs
@@ -32,6 +32,7 @@
 				@click="{{_header.press}}"
 				aria-haspopup="{{menuBtnHasPopup}}"
 				aria-expanded="{{menuPopoverExpanded}}"
+				data-ui5-stable="menuButton"
 			>
 				{{#if hasNonFocusableLogo}}
 					<span
@@ -54,7 +55,7 @@
 		{{/if}}
 
 		{{#if secondaryTitle}}
-			<h2 class="ui5-shellbar-secondary-title">{{secondaryTitle}}</h2>
+			<h2 class="ui5-shellbar-secondary-title" data-ui5-stable="secondaryTitle">{{secondaryTitle}}</h2>
 		{{/if}}
 	</div>
 
@@ -89,6 +90,7 @@
 						<ui5-button
 							@click={{_handleCancelButtonPress}}
 							class="ui5-shellbar-button"
+							data-ui5-stable="cancelSearch"
 						>
 							Cancel
 						</ui5-button>
@@ -107,6 +109,7 @@
 					icon="sap-icon://search"
 					data-ui5-text="Search"
 					data-ui5-notifications-count="{{notificationsCount}}"
+					data-ui5-stable="searchButton"
 					@click={{_handleSearchIconPress}}
 					title="{{_searchText}}"
 					._buttonAccInfo="{{accInfo.search}}"
diff --git a/packages/main/src/TabContainer.hbs b/packages/main/src/TabContainer.hbs
index 2647d0887b69..19ab26c62ecf 100644
--- a/packages/main/src/TabContainer.hbs
+++ b/packages/main/src/TabContainer.hbs
@@ -11,6 +11,7 @@
 			<div class="{{classes.headerBackArrow}}">
 				<ui5-button @click="{{_onHeaderBackArrowClick}}"
 							icon="slim-arrow-left"
+							data-ui5-stable="tabsLeft"
 							design="Transparent"
 							tabindex="-1"
 							title="{{previousIconACCName}}"></ui5-button>
@@ -43,6 +44,7 @@
 			<div class="{{classes.headerForwardArrow}}">
 			<ui5-button @click="{{_onHeaderForwardArrowClick}}"
 						icon="slim-arrow-right"
+						data-ui5-stable="tabsRight"
 						design="Transparent"
 						tabindex="-1"
 						title="{{nextIconACCName}}"></ui5-button>
@@ -59,6 +61,7 @@
 				{{else}}
 					<ui5-button
 						icon="{{overflowMenuIcon}}"
+						data-ui5-stable="tabsOverflow"
 						design="Transparent"
 						tabindex="-1"
 						title="{{overflowMenuTitle}}"

From ac4ed01298ded19062d196da316cc25f18283562 Mon Sep 17 00:00:00 2001
From: Scott McGhee <codefactor@users.noreply.github.com>
Date: Sat, 20 Nov 2021 06:07:41 -0800
Subject: [PATCH 2/3] refactor: changing names of the new stable selectors from
 suggestions in a review

Co-authored-by: Stoehr <stoehr@gmail.com>
---
 packages/fiori/src/ShellBar.hbs    | 8 ++++----
 packages/main/src/TabContainer.hbs | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/packages/fiori/src/ShellBar.hbs b/packages/fiori/src/ShellBar.hbs
index e5cf2cc8b8ad..bbf20fb490e5 100644
--- a/packages/fiori/src/ShellBar.hbs
+++ b/packages/fiori/src/ShellBar.hbs
@@ -32,7 +32,7 @@
 				@click="{{_header.press}}"
 				aria-haspopup="{{menuBtnHasPopup}}"
 				aria-expanded="{{menuPopoverExpanded}}"
-				data-ui5-stable="menuButton"
+				data-ui5-stable="menu"
 			>
 				{{#if hasNonFocusableLogo}}
 					<span
@@ -55,7 +55,7 @@
 		{{/if}}
 
 		{{#if secondaryTitle}}
-			<h2 class="ui5-shellbar-secondary-title" data-ui5-stable="secondaryTitle">{{secondaryTitle}}</h2>
+			<h2 class="ui5-shellbar-secondary-title" data-ui5-stable="secondary-title">{{secondaryTitle}}</h2>
 		{{/if}}
 	</div>
 
@@ -90,7 +90,7 @@
 						<ui5-button
 							@click={{_handleCancelButtonPress}}
 							class="ui5-shellbar-button"
-							data-ui5-stable="cancelSearch"
+							data-ui5-stable="cancel-search"
 						>
 							Cancel
 						</ui5-button>
@@ -109,7 +109,7 @@
 					icon="sap-icon://search"
 					data-ui5-text="Search"
 					data-ui5-notifications-count="{{notificationsCount}}"
-					data-ui5-stable="searchButton"
+					data-ui5-stable="search-button"
 					@click={{_handleSearchIconPress}}
 					title="{{_searchText}}"
 					._buttonAccInfo="{{accInfo.search}}"
diff --git a/packages/main/src/TabContainer.hbs b/packages/main/src/TabContainer.hbs
index 19ab26c62ecf..1747823d700d 100644
--- a/packages/main/src/TabContainer.hbs
+++ b/packages/main/src/TabContainer.hbs
@@ -11,7 +11,7 @@
 			<div class="{{classes.headerBackArrow}}">
 				<ui5-button @click="{{_onHeaderBackArrowClick}}"
 							icon="slim-arrow-left"
-							data-ui5-stable="tabsLeft"
+							data-ui5-stable="tabs-left"
 							design="Transparent"
 							tabindex="-1"
 							title="{{previousIconACCName}}"></ui5-button>
@@ -44,7 +44,7 @@
 			<div class="{{classes.headerForwardArrow}}">
 			<ui5-button @click="{{_onHeaderForwardArrowClick}}"
 						icon="slim-arrow-right"
-						data-ui5-stable="tabsRight"
+						data-ui5-stable="tabs-right"
 						design="Transparent"
 						tabindex="-1"
 						title="{{nextIconACCName}}"></ui5-button>
@@ -61,7 +61,7 @@
 				{{else}}
 					<ui5-button
 						icon="{{overflowMenuIcon}}"
-						data-ui5-stable="tabsOverflow"
+						data-ui5-stable="tabs-overflow"
 						design="Transparent"
 						tabindex="-1"
 						title="{{overflowMenuTitle}}"

From a09e3ef55f1edc4dd3033d9271cd85ff55fea567 Mon Sep 17 00:00:00 2001
From: Scott McGhee <codefactor@users.noreply.github.com>
Date: Mon, 22 Nov 2021 15:05:46 -0800
Subject: [PATCH 3/3] refactor: change selector for search button to be
 "toggle-search"

---
 packages/fiori/src/ShellBar.hbs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/fiori/src/ShellBar.hbs b/packages/fiori/src/ShellBar.hbs
index bbf20fb490e5..70795e2aaab2 100644
--- a/packages/fiori/src/ShellBar.hbs
+++ b/packages/fiori/src/ShellBar.hbs
@@ -109,7 +109,7 @@
 					icon="sap-icon://search"
 					data-ui5-text="Search"
 					data-ui5-notifications-count="{{notificationsCount}}"
-					data-ui5-stable="search-button"
+					data-ui5-stable="toggle-search"
 					@click={{_handleSearchIconPress}}
 					title="{{_searchText}}"
 					._buttonAccInfo="{{accInfo.search}}"