From 53fb6787fca4a5d0c904b7506e1c5b179453b572 Mon Sep 17 00:00:00 2001 From: Philipp Pracht Date: Fri, 14 Jan 2022 10:46:48 +0100 Subject: [PATCH 1/4] adding valid assertion that makes test fail --- packages/main/test/specs/Breadcrumbs.spec.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/main/test/specs/Breadcrumbs.spec.js b/packages/main/test/specs/Breadcrumbs.spec.js index 56821f8562d7..598809b1360f 100644 --- a/packages/main/test/specs/Breadcrumbs.spec.js +++ b/packages/main/test/specs/Breadcrumbs.spec.js @@ -31,6 +31,7 @@ describe("Breadcrumbs general interaction", () => { // Check const eventResult = await browser.$("#result"); + assert.isNotEmpty(eventResult.innerText, 'label should have a value'); assert.strictEqual(eventResult.innerText, link.innerText, "label for pressed link is correct"); }); @@ -50,6 +51,7 @@ describe("Breadcrumbs general interaction", () => { // Check const eventResult = await browser.$("#result"); + assert.isNotEmpty(eventResult.innerText, 'label should have a value'); assert.strictEqual(eventResult.innerText, link.innerText, "label for pressed link is correct"); }); From 1b25c79b639a93f19fedfd3f65689f8a8d12440b Mon Sep 17 00:00:00 2001 From: Philipp Pracht Date: Fri, 14 Jan 2022 10:50:07 +0100 Subject: [PATCH 2/4] assertions to use correct value, tests still fail --- packages/main/test/specs/Breadcrumbs.spec.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/main/test/specs/Breadcrumbs.spec.js b/packages/main/test/specs/Breadcrumbs.spec.js index 598809b1360f..f7de2e66ae97 100644 --- a/packages/main/test/specs/Breadcrumbs.spec.js +++ b/packages/main/test/specs/Breadcrumbs.spec.js @@ -31,8 +31,8 @@ describe("Breadcrumbs general interaction", () => { // Check const eventResult = await browser.$("#result"); - assert.isNotEmpty(eventResult.innerText, 'label should have a value'); - assert.strictEqual(eventResult.innerText, link.innerText, "label for pressed link is correct"); + assert.isNotEmpty(await eventResult.getText(), 'label should have a value'); + assert.strictEqual(await eventResult.getText(), await link.getText(), "label for pressed link is correct"); }); it("fires link-click event when link in overflow", async () => { @@ -51,8 +51,8 @@ describe("Breadcrumbs general interaction", () => { // Check const eventResult = await browser.$("#result"); - assert.isNotEmpty(eventResult.innerText, 'label should have a value'); - assert.strictEqual(eventResult.innerText, link.innerText, "label for pressed link is correct"); + assert.isNotEmpty(await eventResult.getText(), 'label should have a value'); + assert.strictEqual(await eventResult.getText(), await link.getText(), "label for pressed link is correct"); }); it("updates layout on container resize", async () => { From 07d63e58b185f66fdea7dec5a5fb47077d0c86f1 Mon Sep 17 00:00:00 2001 From: Philipp Pracht Date: Fri, 14 Jan 2022 11:10:12 +0100 Subject: [PATCH 3/4] fixed test page using noConflict event, now test setup is correct, test still failing --- packages/main/test/pages/Breadcrumbs.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/main/test/pages/Breadcrumbs.html b/packages/main/test/pages/Breadcrumbs.html index 0df5f8bd16b8..667112c005bf 100644 --- a/packages/main/test/pages/Breadcrumbs.html +++ b/packages/main/test/pages/Breadcrumbs.html @@ -161,7 +161,7 @@

Empty Breadcrumbs with Location only

}); // log events - breadcrumbs1.addEventListener("item-click", (event) => {result.innerText = event.detail.item.innerText}); + breadcrumbs1.addEventListener("ui5-item-click", (event) => {result.innerText = event.detail.item.innerText}); extendSizeBtn.addEventListener("click", () => resizeContainer(true)); shrinkSizeBtn.addEventListener("click", () => resizeContainer()); From 28fe79859c8f4e2dbb8db2463661af54614eae90 Mon Sep 17 00:00:00 2001 From: Philipp Pracht Date: Fri, 14 Jan 2022 11:51:58 +0100 Subject: [PATCH 4/4] fixed test logic, tests are passing now --- packages/main/test/specs/Breadcrumbs.spec.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/main/test/specs/Breadcrumbs.spec.js b/packages/main/test/specs/Breadcrumbs.spec.js index f7de2e66ae97..207ec2820751 100644 --- a/packages/main/test/specs/Breadcrumbs.spec.js +++ b/packages/main/test/specs/Breadcrumbs.spec.js @@ -37,8 +37,7 @@ describe("Breadcrumbs general interaction", () => { it("fires link-click event when link in overflow", async () => { const breadcrumbs = await browser.$("#breadcrumbs1"), - overflowArrowLink = (await breadcrumbs.shadow$$("ui5-link"))[0], - link = (await breadcrumbs.shadow$$("ui5-link"))[1]; + overflowArrowLink = (await breadcrumbs.shadow$$("ui5-link"))[0]; // Act @@ -52,7 +51,7 @@ describe("Breadcrumbs general interaction", () => { // Check const eventResult = await browser.$("#result"); assert.isNotEmpty(await eventResult.getText(), 'label should have a value'); - assert.strictEqual(await eventResult.getText(), await link.getText(), "label for pressed link is correct"); + assert.strictEqual(await eventResult.getText(), await firstItem.getProperty('innerText'), "label for pressed link is correct"); }); it("updates layout on container resize", async () => {