Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord notice in Contributing.rst is misleading #4632

Open
dustdfg opened this issue Nov 12, 2024 · 9 comments
Open

Discord notice in Contributing.rst is misleading #4632

dustdfg opened this issue Nov 12, 2024 · 9 comments

Comments

@dustdfg
Copy link
Contributor

dustdfg commented Nov 12, 2024

screen-1731402599

scons/CONTRIBUTING.rst

Lines 16 to 22 in b4d72c7

If you're going to contribute, we'd love to get to know you
a bit and understand and what problems you're looking to solve,
or what you are intending to improve, whether that's documentation,
code, examples, tutorials, etc. A great way to introduce yourself is to
to hop onto the `SCons Discord Server <https://discord.gg/bXVpWAy>`_
to chat. You don't have to be a regular Discord user,
there is a web interface.

@bdbaddog
Copy link
Contributor

Feel free to PR if you feel this language isn't clear enough.

@dustdfg
Copy link
Contributor Author

dustdfg commented Nov 13, 2024

Regular discord user is registered discord user in my opinion... And I am bad at descriptive and sound strings of text so... And tbh I am even not sure what was meant in here. Something like we have discord is ok but everything else?

@mwichmann
Copy link
Collaborator

Will be happy to think about different wording if had a better idea what was confusing about this.

The "project description" files like the READMEs and so forth haven't had as much editing attention as the SCons documentation.

@dustdfg
Copy link
Contributor Author

dustdfg commented Nov 13, 2024

Will be happy to think about different wording if had a better idea what was confusing about this.

My interpretation of what I read: "We have discord. You doesn't need to be register in discord to contact us. Oh and discord also have a web interface"

But when I open it I see that I must register to write something so...

@mwichmann
Copy link
Collaborator

my system has gone wonky so I can't really check if the web interface still works (it keeps redirecting me). may be that commenting is no longer possible without being "signed in", in which case we should take that out.

@bdbaddog
Copy link
Contributor

@dustdfg - please suggest other language if you'd like to see a change here. You're the first user who was confused by the language (or at least the first that let us know). Pretty sure "regular" meant to mean an installed app and not a web page..

@mwichmann
Copy link
Collaborator

I guess we should check if the web interface (a) still works at all and (b) allows writing to an SCons server channel without being logged in, and if not, removing the mention of the web interface. My belief, which I can't easily test because my browser "helpfully" vectors over to the app due to some remembered information, is that you can use it, but login is required to post...

@dustdfg
Copy link
Contributor Author

dustdfg commented Nov 14, 2024

I guess we should check if the web interface (a) still works at all and

It works, at least for me. The initial screenshot is a screenshot of what I saw in web version

@kprussing
Copy link
Contributor

For reference, I use the web interface to participate, but I did have to make an account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants