-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LPAR name as prefix of thread names #577
Comments
That sounds like a quite good and perfectly reasonable request! Thanks Drew! I'll get right on it as soon as I can! |
You are most kind. I thought it would easier than some. BTW, my example only showed CPU threads, but getting all reasonable threads would be great. |
One caveat though: I'm pretty sure on Windows that thread names are limited to 16 characters (or maybe 15; can't recall). I think Linux might impose a limit too, but am not sure about that, nor what the limit actually is if it does. Prefixing each thread's name with the LPARNAME could end up being a little tricky depending on how long your LPAR name is! |
It looks like *Nix imposes a maximum length of only 15 characters: |
Hercules code: Lines 1647 to 1673 in 65c97fd
|
Any ideas, Drew? (Or anyone else?) |
Take whole LPAR name if possible, space, seven characters for the thread data: CPxx What other types do you have? Sometimes, you gotta think like a S/360 programmer lop stuff down to size. We close with a reading from the tenth edition (May 1990) of the IBM Jargon dictionary, edited by IBM Fellow Mike Cowlishaw:
(Of course, Cowlishaw is nine characters.) |
Lines 245 to 275 in 65c97fd
|
|
FYI: I would replace something like this with LPARNAME HERC. |
I'm also thinking this should probably be a new command-line option too, so the user can choose on a case-by-case basis whether they want thread names to be prefixed with some user-defined value or not. That is to say, prefixing thread names with the LPARNAME, now that I think about it, might not be possible (or at least more difficult) to implement, given that the LPARNAME won't be known until the configuration files is processed (and, although I haven't checked, I believe some threads might get created before the LPARNAME has been processed and is known). What do you think? New command-line option? |
I like it! |
If you want, but since on Linux by default |
Commenting on this partial display from a running system:
|
Eh?! What's this?! If I'm confused! |
I bad. (Original comment corrected.)
should read:
Threads are enabled by capital |
Huh? in |
More context please. What in
|
I see no effect using |
Makes sense.
Also makes perfect sense.
Nah. Dasd code and CCKD code are quite different things internally. As "dasd" and "cckd" are both 4 characters, I'm compelled to leave those as-is if you don't mind.
Again, no. The "ra" in the name stands for "read ahead":
|
Are you running threaded apps? I specifically said I was using Bullseye (actually Raspberry PI OS B Bullseye); the I also verified this on Hint: The second line of the -ahd- |
I don't know.
I did notice the change to "Threads". But nothing special was running at the time. |
SGTM |
When running multiple Hercules instances, if one shows threads on Linux one ends up with multiple names like "Processor CP00". It would be more useful to say "LPARNAME Processor CP00" or even "LPARNAME CP00"
The text was updated successfully, but these errors were encountered: