-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using the macro BUILD_APPLE_M1 set by configure prevents a universal build #617
Comments
Good idea. |
I'm afraid I do not understand the problem you are reporting, nor what your suggested fix for the problem is, Enrico. "the title tells" is not enough for me. I am not familiar with Apple "Universal" builds. Do you have a patch for us? (Bill? Do you understand what Enrico is saying?) |
Fish, Yes, I understand. Enrico and I will take care of it. Bill |
Thanks! |
This will be an improvement going forward, but nothing urgent. |
when building a universal binary the apple compiler will logically run twice one time with the __arm64 macro, PS |
Ah! Okay! That makes sense now. I think I now know what your GitHub Issue is referring to. Thanks, Enrico!
Thank you. We would appreciate that very much! |
You can blame me for how it is now. When I arrived here SDL Hercules didn't build at all on quite a few platforms, including modern Mac. What we have now is the result of me buying a Mac M1 at Costco and just dicking with it. Bill |
Lucky you! I wish I could afford one.
I was a huge fan of the Macintosh when it originally came out oh so many years ago. Bought myself a "Fat" Mac (512K!) with a dot matrix printer and installed a 3rd party internal (10MB!) hard drive! I was in heaven! Sadly, I had to sell it a few years later for the money. And of course today, I'm so dirt poor I couldn't get out of sight if it cost a quarter (25 cents) to go around the world! |
Bill Lewis (@wrljet) wrote:
Enrico Sorichetti (@atncsj6h) wrote:
(Ping!) How's is going, guys? Still no rush. Just curious is all. |
I had some personal urgencies to take care of, here the git diff output at the current hyperion level |
My best wishes and thoughts go out to you my friend!
Thanks! I'll take a peek at them and then probably go ahead and commit them if they look okay (which I'm sure they will). Good luck with your personal urgency! I wish you nothing but the best, and hope things go well for you. Take care, my friend. |
thank you, |
(PING!) How's it going you two? Is this issue resolved yet? Any progress? are you still working on it? Or can it be closed? Just interested in a status update, that's all. If I should leave it open, fine. Just let me know. Thanks. |
Please don't close. Still needs to be addressed. Just lot of other stuff going on. |
No problem. I was just under the impression that it was a fairly simple and straightforward thing, that's all. Sorry to bother you. Will keep open as long as needed. |
(PING!) Status? |
(PING!?!)Status?!? |
the title tells
no need to bother configure.ac
for this checks the builtin compiler macros should be used
generic
will use the qos constructs also for x86_64 processors
I do not know what happens under the covers but an arm64 universal works on a macbook Intel
more granularity / pickyness
the compiler will use the qos contructs for arm
the old constructs for x86_64
e
P.S.
should always be run when updating the compiler
to find the new macros available
The text was updated successfully, but these errors were encountered: