Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jinja2 with mako #1273

Closed
TheJJ opened this issue May 22, 2020 · 2 comments · Fixed by #1527
Closed

Replace jinja2 with mako #1273

TheJJ opened this issue May 22, 2020 · 2 comments · Fixed by #1527
Labels
good first issue Suitable for newcomers improvement Enhancement of an existing component lang: python Done in Python code

Comments

@TheJJ
Copy link
Member

TheJJ commented May 22, 2020

Due to personal experience I'd really like to replace jinja2 with mako templates instead.

We only use jinja in openage/codegen/coord.py.

Really not high priority :)
@TheJJ TheJJ added improvement Enhancement of an existing component lang: python Done in Python code good first issue Suitable for newcomers labels May 22, 2020
@Brodan
Copy link

Brodan commented Oct 19, 2020

Hi, I'm a newbie looking to contribute and this looks like a cool first issue that I can actually wrap my head around. Any chance the hacktoberfest label can be added so it could count towards my contributions?

@heinezen heinezen added the hacktoberfest For newcomers from Hacktoberfest event label Oct 19, 2020
@heinezen
Copy link
Member

@Brodan Sure, you can go for it :)

@heinezen heinezen removed the hacktoberfest For newcomers from Hacktoberfest event label Nov 4, 2020
@zoli111 zoli111 mentioned this issue Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Suitable for newcomers improvement Enhancement of an existing component lang: python Done in Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Mako instead of Jinja2
3 participants
@TheJJ @heinezen @Brodan