Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchanted books and items not displayed correctly #2

Closed
d4rkm0nkey opened this issue Jun 15, 2021 · 13 comments
Closed

Enchanted books and items not displayed correctly #2

d4rkm0nkey opened this issue Jun 15, 2021 · 13 comments

Comments

@d4rkm0nkey
Copy link

When I use the mod, enchanted books in item frames look like normal books and enchanted items look like normal items.

I am using Sodium and Iris.

@SFort SFort added the invalid This doesn't seem right label Jun 15, 2021
@SFort
Copy link
Owner

SFort commented Jun 15, 2021

Yup this does seem to be a conflict
sry for assuming invalid i just didn't think this could happen

@SFort SFort removed the invalid This doesn't seem right label Jun 15, 2021
@d4rkm0nkey
Copy link
Author

No I have not. My mods:

Animal Feeding Trough
Architect's Palette Fabric
Architectury
Artificial Foliage
Bamboo Tweaks
Cardinal Components API
Color Unchained
Dehydration
EditSign
EnvironmentZ
Extra Pieces
Fabric API
Fabric Language Kotlin
FerriteCore
Gilded Netherite
Gunpowder
Gunpowder Currency
Gunpowder Signshop
Invisible Frames
Iris
Item Scroller
Krypton
LambDynamicLights
Lithium
MaLiLib
Mannequins
Mo' Structures
Mo'Enchantments
Mobs Attempt Parkour
Mod Menu
Oh, How the Crafting Has Tabled!
Ok Zoomer
Phosphor
Puddles
Repurposed Structures
Shop Visualizer
Sodium
TridentReturn
Trinkets

@d4rkm0nkey
Copy link
Author

When I remove Invisible Frames it works again.

@SFort SFort closed this as completed in ba16a0c Jun 15, 2021
@SFort
Copy link
Owner

SFort commented Jun 15, 2021

At this point i have deleated a lot of comments because every time i did a test there was a compleatly diffrent result

this issue only turns up when iris, invis frames, lithium, sodium are installed and additionally possibly for only certain versions

thanks for the report but this has been a nightware to debug

@d4rkm0nkey
Copy link
Author

Thank you for fixing this so fast!! I am currently doing a Youtube video and your mod is so helpful for it!

@d4rkm0nkey
Copy link
Author

But what did you exactly change except the version number?

@SFort
Copy link
Owner

SFort commented Jun 15, 2021

see 64c1fef
practically all that's changed in v2.0.2
is the mappings ware updated from 1.16.2+build.1 to 1.17+build.5

@d4rkm0nkey
Copy link
Author

ah ok. Can you release a fix for version 1.16.5 as well? I guess most people still play on it.

@SFort
Copy link
Owner

SFort commented Jun 15, 2021

should be backwards compatible nothing was actually changed code wise

@d4rkm0nkey
Copy link
Author

Yes, I tested it and it works! Thank you!

@d4rkm0nkey
Copy link
Author

hmm I am confused. It only works sometimes...
Started the game four times without changing any mod. Two times it worked and two times not.

@SFort
Copy link
Owner

SFort commented Jun 15, 2021

amazing. theres nothing more i can really do though.
you're gonna have to ask the devs of the other mods.
(maybe make sure all the mods are updated?)

@SFort
Copy link
Owner

SFort commented Aug 9, 2021

@d4rkm0nkey as this issue is still a mystery in case you can still reproduce it.
mind giving the newest version a try with setting the item check to server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants