Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid range_min value in LaserScan message #382

Closed
maracuya-robotics opened this issue Aug 19, 2024 · 1 comment
Closed

Invalid range_min value in LaserScan message #382

maracuya-robotics opened this issue Aug 19, 2024 · 1 comment

Comments

@maracuya-robotics
Copy link

maracuya-robotics commented Aug 19, 2024

While using sick_scan_xd with a SICK picoScan150, I noticed that the range_min field of the sensor_msgs/LaserScan message is always set to 0.0. At the same time, invalid range measurements are set to zero. According to the definition of the message invalid measurements should not be included within this range:

float32[] ranges         # range data [m] (Note: values < range_min or > range_max should be discarded)

The documentation says that the picoScan150 has a design limitation of range_min = 0.05, therefore range_min should be set to this value in the message. Alternatively define invalid scans as NaN or +infinity.

@rostest
Copy link
Collaborator

rostest commented Aug 20, 2024

Thank you very much for your feedback. We will correct range_min in the sensor_msgs/LaserScan messages in the next release. In the meantime please replace line 846 in driver/src/sick_scansegment_xd/ros_msgpack_publisher.cpp by 0.05f for multiScan and picoScan:

laser_scan_msg.range_min = std::max(0.05f, laser_scan_msg.range_min); // min range of multiScan and picoScan: 0.05 [m]

@rostest rostest closed this as completed Sep 25, 2024
weinmalSICKAG added a commit that referenced this issue Oct 23, 2024
* add: Launchfiles and configuration for picoScan120
* add: Optional AngleRangeFilter and IntervalFilter for picoScan
* fix: Obsolete topic "/sick_multiscan/scan" removed
* add: IMU automatically deactivated after receiving an error code for IMU activation from picoScan w/o addons
* fix: Customization of hash values for authorization #366
* fix: Replaced builtin_addressof expressions #370
* add: Different UDP timeouts for state initial and running, improved UDP timeout handling
* fix: Picoscan range_min value in laserScan message #382
* add: Support for RMS2xxx LIDoutputstate telegrams
* fix: sick_generic_caller debug assertion #385
* add: Check of udp receiver ip at startup
* add: cmake-option to overwrite optimization level
* change: Documentation restructured
* add: Improved field evaluation TiM7xx, Tim7xxS (publish LIDinputstate messages, configuration and services for options FieldSetSelectionMethod and ActiveFieldSet)
* fix: PicoScan parameter add_transform_xyz_rpy #399
* fix: LMS4000 encoder settings #403
* fix: CMake-flag for target sick_scan_xd_api_dockertest #404
* change: Merge PR #405 (typo) and PR #406 (sick_scan_xd_api_test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants