-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in documentation and asdict #811
Comments
Agree, it might be little confusing. SOFT5 had slightly different ways to serialise entities and instances as JSON, which DLite inherited. In DLite we call these two serialisation forms for single-entity form (entities) and multi-entity form (instances). The PR #833 changes the default to single-entity form for entities and multi-entity form for instances. This may be easier to use, but changes the behaviour of DLite and may break existing code. An alternative would be to always use the more general multi-entity form as the default. |
I think that it is necessary to clarify what DLite is supposed to do before aligning one way or the other. As it might be a breaking change, it would require a new version and so it might be worth considering what that version should look like. |
In the documentation it is specified: uri: An optional unique name identifying the instance
But a dictionary without that key cannot be load from a json file.
The function asdict produces a dictionary that does not contain uri but uuid.
The text was updated successfully, but these errors were encountered: