Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat document links as definitions #605

Closed
pca006132 opened this issue Jul 25, 2020 · 1 comment
Closed

Treat document links as definitions #605

pca006132 opened this issue Jul 25, 2020 · 1 comment
Assignees
@SPGoding
Labels
✨ feature New feature or request ♻ refactor Refactor code *released The changes has been released
Milestone
Release 3.0.0

Comments

@pca006132
Copy link

For vim users, we typically use gd to goto definition.
In most of the language servers, references to other documents are also treated as definitions, such as c++ #include "path".
In DHP, references to functions are treated as document links only. So we cannot use gd to jump to the file directly.
@SPGoding SPGoding self-assigned this Jul 30, 2020
@SPGoding SPGoding added ♻ refactor Refactor code ✨ feature New feature or request 🔷 lsp labels Jul 30, 2020
@SPGoding SPGoding added this to the Release 3.0.0 milestone Jul 30, 2020
SPGoding added a commit that referenced this issue Jul 30, 2020
@SPGoding
✨ Treat files as definitions of namespaced IDs
7a4a964 
Resolve #605.
@SPGoding SPGoding mentioned this issue Jul 30, 2020
Closed
SPGoding added a commit that referenced this issue Jul 30, 2020
@SPGoding
✨ Treat files as definitions of namespaced IDs (#608)
36106ea 
* ✨ Treat files as definitions of namespaced IDs

Resolve #605.

Also, the process of fetching VanillaData has been improved to cache the whole Promise instead of caching the result, so that the same data for the same version won't be fetched multiple times.

* 👥 Update contributors
@SPGoding
Copy link
Member

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SPGoding SPGoding added the *released The changes has been released label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SPGoding SPGoding

Labels
✨ feature New feature or request ♻ refactor Refactor code *released The changes has been released
Projects
None yet
Milestone
Release 3.0.0
Development

No branches or pull requests
2 participants
@pca006132 @SPGoding