Further reactification #1359
Merged
Further reactification #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing a global variable by a pseudo-global React context.
Let’s make it a React hook to allow caching the value. Ideally, we would create the sharers once in EntriesPage and then pass them down but that would break custom sharers since the `user.js` may take some time to load.
jtojnar
force-pushed
the
more-reactification
branch
from
8aee5ee
to
3f8c985
Compare
Requires attaching App after `selfoss.loggedin` is updated.
The jQuery removal was long coming. Since the next version of Fancybox is unfree, let’s switch to something else.
It is bit more maintained and looks better.
jtojnar
force-pushed
the
more-reactification
branch
from
6b11c5c
to
773db11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes parcel-bundler/parcel#8382 by removing jQuery.