Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Miniplayer - Editor #930

Open
MaterArc opened this issue Jul 16, 2024 · 0 comments · May be fixed by #963
Open

Project Miniplayer - Editor #930

MaterArc opened this issue Jul 16, 2024 · 0 comments · May be fixed by #963
Labels
priority: 2 The 2nd most important. scope: feature status: needs review Waiting for further review. type: bug Something isn't working

Comments

@MaterArc
Copy link
Member

MaterArc commented Jul 16, 2024

Describe the bug. What is going wrong?

Screenshot 2024-07-16 at 4 41 37 PM

Project Miniplayer box shows up in the editor

What is causing the bug?

The problem seems to be with the fact that the Project Miniplayer feature's runOn is set to /projects/* and that includes the editor as well. There also isn't a code-side check to prevent this from happening in the editor itself either. This should be a relatively easy fix with the Location module paired with the pathname property.

Note: You may need to scroll down to the comments of any project and then open the editor to reproduce this bug

Anything else?

No response

@MaterArc MaterArc added type: bug Something isn't working status: needs review Waiting for further review. labels Jul 16, 2024
@rgantzos rgantzos added priority: 2 The 2nd most important. scope: feature labels Jul 16, 2024
@Masaabu Masaabu linked a pull request Sep 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 2 The 2nd most important. scope: feature status: needs review Waiting for further review. type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants