Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Jinja cached include #168

Merged
merged 3 commits into from
May 19, 2021
Merged

Conversation

indy-independence
Copy link
Member

Make template includes relative to parent template, this solves issues where eos/dist.j2 would sometimes include junos/dist-interfaces.j2 and vice versa

@indy-independence indy-independence marked this pull request as draft May 18, 2021 14:53
@indy-independence indy-independence marked this pull request as ready for review May 18, 2021 14:53
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #168 (6580403) into develop (9d9c3ef) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #168      +/-   ##
===========================================
- Coverage    58.33%   58.21%   -0.12%     
===========================================
  Files           59       59              
  Lines         5942     5945       +3     
===========================================
- Hits          3466     3461       -5     
- Misses        2476     2484       +8     
Impacted Files Coverage Δ
src/cnaas_nms/confpush/nornir_helper.py 68.51% <100.00%> (-25.60%) ⬇️
src/cnaas_nms/db/helper.py 49.18% <0.00%> (-11.48%) ⬇️
src/cnaas_nms/db/settings.py 80.63% <0.00%> (ø)
src/cnaas_nms/api/groups.py 81.25% <0.00%> (+20.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9c3ef...6580403. Read the comment docs.

@indy-independence indy-independence merged commit c906d0a into develop May 19, 2021
@indy-independence indy-independence deleted the bugfix.jinja_cached_include branch May 19, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant