Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ifclass port_template_esx for exmaple [settings] #193

Merged
merged 3 commits into from
Sep 7, 2021

Conversation

indy-independence
Copy link
Member

@indy-independence indy-independence commented Sep 6, 2021

Has to be defined by user in jinja template

@indy-independence indy-independence changed the title Allow ifclass port_template_esx for exmaple. Has to be defined by use… Allow ifclass port_template_esx for exmaple Sep 6, 2021
@indy-independence
Copy link
Member Author

Maybe it would even be possible for both access switches with configtype: TEMPLATE and dist switches with ifclass: port_template to use the same jinja template if both files include the same port-templates.j2 and define same variable name?

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #193 (22656d5) into develop (e038a28) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #193      +/-   ##
===========================================
+ Coverage    59.01%   59.02%   +0.01%     
===========================================
  Files           60       60              
  Lines         6058     6058              
===========================================
+ Hits          3575     3576       +1     
+ Misses        2483     2482       -1     
Impacted Files Coverage Δ
src/cnaas_nms/db/settings_fields.py 94.76% <100.00%> (ø)
src/cnaas_nms/confpush/sync_devices.py 71.46% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e038a28...22656d5. Read the comment docs.

@indy-independence indy-independence changed the title Allow ifclass port_template_esx for exmaple Allow ifclass port_template_esx for exmaple [settings] Sep 7, 2021
@indy-independence indy-independence marked this pull request as ready for review September 7, 2021 13:33
@indy-independence indy-independence merged commit 6acfe8a into develop Sep 7, 2021
@indy-independence indy-independence deleted the feature.dist_ifclass_port_template branch September 7, 2021 13:33
@indy-independence indy-independence added this to the v1.3.0 milestone Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant