From a9deac7d194e05610295b5d739336bf8b8a5468a Mon Sep 17 00:00:00 2001 From: travisn Date: Fri, 30 Aug 2019 13:46:38 -0600 Subject: [PATCH] ceph: clean up verbose logging The log messages for orchestrations being skipped due to nodes still being schedulable or unschedulable is filling the logs and not necessary. The log message for reconciling is now debug, and also fixed another formatting log message. Signed-off-by: travisn --- pkg/operator/ceph/cluster/controller.go | 6 +++--- pkg/operator/ceph/disruption/clusterdisruption/reconcile.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/operator/ceph/cluster/controller.go b/pkg/operator/ceph/cluster/controller.go index 04dcbc111964..c6aff70dddc5 100644 --- a/pkg/operator/ceph/cluster/controller.go +++ b/pkg/operator/ceph/cluster/controller.go @@ -486,11 +486,11 @@ func (c *ClusterController) onK8sNodeUpdate(oldObj, newObj interface{}) { // Checking for NoSchedule added to storage node if oldNodeSchedulable == false && newNodeSchedulable == false { - logger.Debugf("Skipping cluster update. Updated node %s was and is still unschedulable", newNode.Labels[v1.LabelHostname]) + // Skipping cluster update. Updated node was and is still unschedulable return } if oldNodeSchedulable == true && newNodeSchedulable == true { - logger.Debugf("Skipping cluster update. Updated node %s was and it is still schedulable", oldNode.Labels[v1.LabelHostname]) + // Skipping cluster update. Updated node was and is still schedulable return } @@ -711,7 +711,7 @@ func (c *ClusterController) onDeviceCMUpdate(oldObj, newObj interface{}) { for _, cluster := range c.clusterMap { if cluster.Info == nil { - logger.Info("Cluster %s is not ready. Skipping orchestration on device change", cluster.Namespace) + logger.Infof("Cluster %s is not ready. Skipping orchestration on device change", cluster.Namespace) continue } logger.Infof("Running orchestration for namespace %s after device change", cluster.Namespace) diff --git a/pkg/operator/ceph/disruption/clusterdisruption/reconcile.go b/pkg/operator/ceph/disruption/clusterdisruption/reconcile.go index eb80923e56b5..83c1a8a3f4eb 100644 --- a/pkg/operator/ceph/disruption/clusterdisruption/reconcile.go +++ b/pkg/operator/ceph/disruption/clusterdisruption/reconcile.go @@ -92,7 +92,7 @@ func (r *ReconcileClusterDisruption) reconcile(request reconcile.Request) (recon logger.Debugf("discovered NamespacedName: %s", request.NamespacedName) } r.namelessRetries = 0 - logger.Infof("reconciling %s", request.NamespacedName) + logger.Debugf("reconciling %s", request.NamespacedName) // get the ceph cluster cephCluster := &cephv1.CephCluster{}