Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement config flag for multiple config files #16

Merged
merged 15 commits into from
Mar 17, 2020
Merged

Implement config flag for multiple config files #16

merged 15 commits into from
Mar 17, 2020

Conversation

MalloZup
Copy link
Contributor

@MalloZup MalloZup commented Mar 16, 2020 •
edited
Loading

what does this PR?

  • add config flag. if this is set, the file is read from the path.
  • change service file to be called multiple times

@MalloZup MalloZup added the wip work in progress, don't merge label Mar 16, 2020
@MalloZup MalloZup changed the title WIP: Add initial implementation of custom config file Implement config flag for multiple config files Mar 17, 2020
@MalloZup MalloZup removed the wip work in progress, don't merge label Mar 17, 2020
MalloZup
MalloZup commented Mar 17, 2020
View reviewed changes
main.go Show resolved Hide resolved
MalloZup
MalloZup commented Mar 17, 2020
View reviewed changes
main.go Outdated Show resolved Hide resolved
@MalloZup
Copy link
Contributor Author

SUSE/sapnwbootstrap-formula#40

@MalloZup
Copy link
Contributor Author

we need to think now how to pass config to daemon. I'm doing right now

stefanotorresi
stefanotorresi requested changes Mar 17, 2020
View reviewed changes
Copy link
Collaborator

@stefanotorresi stefanotorresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Dario!! Just a minor remark about the configuration copy in the RPM.

README.md Outdated Show resolved Hide resolved
packaging/obs/prometheus-sap_host_exporter.spec Outdated Show resolved Hide resolved
MalloZup and others added 2 commits March 17, 2020 16:31
@MalloZup @stefanotorresi
Update packaging/obs/prometheus-sap_host_exporter.spec
90b70e6 
Co-Authored-By: Stefano Torresi <stefano@torresi.io>
@MalloZup
Rename file
a257308
@stefanotorresi stefanotorresi merged commit fa6bd15 into SUSE:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanotorresi stefanotorresi stefanotorresi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MalloZup @stefanotorresi