From 6deff4b872a5d379d172134733bc3f1285012834 Mon Sep 17 00:00:00 2001 From: Lars Reimann Date: Tue, 21 Mar 2023 23:01:41 +0100 Subject: [PATCH 1/2] ci: also build with Python v3.11 --- .github/workflows/main.yml | 6 +++++- .github/workflows/pr.yml | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index bed0db69..32ea80eb 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -7,10 +7,14 @@ on: jobs: poetry-with-codecov: strategy: + fail-fast: false matrix: - python-version: [ "3.10" ] + python-version: + - "3.10" + - "3.11" uses: lars-reimann/.github/.github/workflows/poetry-codecov-reusable.yml@main with: working-directory: . python-version: ${{ matrix.python-version }} module-name: library_analyzer + coverage: ${{ matrix.python-version == '3.10' }} diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 1c48d485..2faa3b36 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -11,10 +11,14 @@ concurrency: jobs: poetry-with-codecov: strategy: + fail-fast: false matrix: - python-version: [ "3.10" ] + python-version: + - "3.10" + - "3.11" uses: lars-reimann/.github/.github/workflows/poetry-codecov-reusable.yml@main with: working-directory: . python-version: ${{ matrix.python-version }} module-name: library_analyzer + coverage: ${{ matrix.python-version == '3.10' }} From f9869a8987321d340c53e988ac8ae417c46f8869 Mon Sep 17 00:00:00 2001 From: Lars Reimann Date: Wed, 22 Mar 2023 11:01:19 +0100 Subject: [PATCH 2/2] fix: don't call `version` with an empty string --- src/library_analyzer/processing/api/_package_metadata.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/library_analyzer/processing/api/_package_metadata.py b/src/library_analyzer/processing/api/_package_metadata.py index 5d45c8cb..0a119de2 100644 --- a/src/library_analyzer/processing/api/_package_metadata.py +++ b/src/library_analyzer/processing/api/_package_metadata.py @@ -44,7 +44,7 @@ def distribution(package_name: str) -> Optional[str]: def distribution_version(dist: Optional[str]) -> Optional[str]: - if dist is None: + if dist is None or len(dist) == 0: return None return version(dist)