-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytest can't detect 2 or more outliers in a function #274
Comments
The test function should also be changed to A new test should also be added to catch the incorrect old behaviour. |
The current function can remove mutliple outliers. It is possible that you added another high value but with this addition the outliers were no outliers anymore because of the small data you used to test this. In #309 I added 2 new tests that test mutliple outliers in different columns and multiple outliers in the same column. |
…le outliers in one column and outliers in two different columns (#309) ### Summary of Changes test: Added test for `Table.remove_rows_with_outliers` to test multiple outliers in one column and outliers in two different columns See my [Comment](#274 (comment)) in the referenced issue for further explanation as there is no bug with the current method `Table.remove_rows_with_outliers` ### Additional Context See #274 --------- Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com> Co-authored-by: Severin Paul Höfer <84280965+zzril@users.noreply.github.com>
Describe the bug
The following function: def remove_rows_with_outliers doesn't perform its function correctly because it can only detect and remove a maximum of 1 outlier. That is, 2 or more outliers should be removed but that doesn't work.
To Reproduce
Expected behavior
All Outliers should be detected and removed.
Screenshots (optional)
No response
Additional Context (optional)
No response
The text was updated successfully, but these errors were encountered: