Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generated the page before the "has already a wallet?" check #29

Open
karelstriegel opened this issue Oct 29, 2018 · 1 comment
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@karelstriegel
Copy link

When thorblock gets permission to access arkane the user is send back to thorblock, then a check is performed to see if the user already has a linked wallet, if not he is again redirected to arkane. In this case the thorblock page is already build and the user briefly sees an error. A better implementation could be to perform the check and if needed the redirect, before the page in build.

image

@karelstriegel karelstriegel added bug Something isn't working enhancement New feature or request labels Oct 29, 2018
@wijzijnwolf
Copy link

The wallet check was performed in PHP using the API.
On the dashboard page it now uses the arkaneConnect.getWallets call

The my wallets page still uses the php api call though (but by the time you navigate there, you should have a wallet already)

I haven't tested the above with a new account yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants