Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle newlines in autocomplete suggestions #110

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

eero-lehtinen
Copy link
Contributor

@eero-lehtinen eero-lehtinen commented Oct 13, 2024

Fixes #109

Escapes newlines in autocomplete to avoid errors.

Now doesn't error (second item has newlines):
image

@Saghen
Copy link
Owner

Saghen commented Oct 13, 2024

Thanks! Do me a favor and add a small comment above that line explaining why. Also, maybe create a new field on the context called label with the fix and leave the item as-is

@eero-lehtinen eero-lehtinen force-pushed the fix-suggestion-newlines branch from 33946d6 to 02cd7d6 Compare October 13, 2024 23:18
@eero-lehtinen eero-lehtinen force-pushed the fix-suggestion-newlines branch from 02cd7d6 to a50c0c3 Compare October 13, 2024 23:27
@Saghen Saghen merged commit c39227a into Saghen:main Oct 14, 2024
@Saghen
Copy link
Owner

Saghen commented Oct 14, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete errors when suggestions contain newlines
2 participants