Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signature help now highlights the right parameter #297

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

grecodavide
Copy link
Contributor

Currently, signature help does not highlight the current parameter but always starts from the second character (see image)
image_2024-11-08_11-49-02

By using the right indexes, this gets fixed:
image_2024-11-08_11-50-12

@Saghen
Copy link
Owner

Saghen commented Nov 8, 2024

What version of neovim are you on? I'm unable to reproduce this on nvim 0.10.2

@grecodavide
Copy link
Contributor Author

grecodavide commented Nov 8, 2024

I am on v0.11.0-dev-1106+gf7e32fb6e6

EDIT:
To provide additional information, I checked convert_signature_help_to_markdown_lines in vim/lsp/util.lua and can confirm that it returns a table like this:

{start_row, start_col, end_row, end_col}

@grecodavide grecodavide reopened this Nov 10, 2024
@grecodavide
Copy link
Contributor Author

With this commit the hl should work as expected in both versions

@Saghen Saghen merged commit 3fe4c75 into Saghen:main Nov 10, 2024
@Saghen
Copy link
Owner

Saghen commented Nov 10, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants