Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<C-k> keymap overwritten by LazyVim LSP keymap #37

Closed
stefanboca opened this issue Oct 8, 2024 · 2 comments
Closed

<C-k> keymap overwritten by LazyVim LSP keymap #37

stefanboca opened this issue Oct 8, 2024 · 2 comments

Comments

@stefanboca
Copy link
Collaborator

stefanboca commented Oct 8, 2024

I'm trying out this plugin with LazyVim and noticed that the <C-k> keybinding is instead being bound for LSP signature help by LazyVim.

After adding vim.notify statements to the functions that add keybindings for both blink.cmp and LazyVim's LSP, I found that LazyVim's bindings are being set after blink.cmp, overwriting the mapping.

Interesting to note is that this works in nvim-cmp because they set key bindings on the first InsertEnter.

@stefanboca stefanboca changed the title <C-K> keymap overwritten by LazyVim LSP keymap <C-k> keymap overwritten by LazyVim LSP keymap Oct 8, 2024
@Saghen
Copy link
Owner

Saghen commented Oct 8, 2024

Should be fixed with 506ea74

@Saghen Saghen closed this as completed Oct 8, 2024
@stefanboca
Copy link
Collaborator Author

Thank you for the quick response.

I just pulled the latest changes and this issue still persists. It looks like 506ea74 fixes the case where blink overrides pre-existing buffer mappings. However, my issue is that blink is binding <C-k>, which is then overwritten by LazyVim.

I believe the reason I didn't previously have this issue with nvim-cmp is because nvim-cmp sets keymaps on the InsertEnter event, rather than on BufEnter (which occurs after LazyVim sets the <C-k> keybind, overriding blink).

@Saghen Saghen reopened this Oct 8, 2024
@Saghen Saghen closed this as completed in 340370d Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants