fix(highlight): fix invalid highlight for doc separator #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add default highlight in default config and README
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found highlight group for separator not work, and no description for the highlight group in README.
Not familiar with
nvim_buf_set_extmark, but it seems work fine.Before ( separator in doc window should be RED
#9e2e2eafter setting highlight group) :After (highlight group works)
Also I think maybe previous highlight group naming (
BlinkCmpDocDetail) have some ambiguity, therefore currently usingBlinkCmpDocSeparatoras a substitute in the PR.