Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render): not render two separator for doc window #451

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

tim3nd
Copy link
Contributor

@tim3nd tim3nd commented Dec 5, 2024

Some LSP servers like lua_ls would return --- for function doc, so the manually added separator would make two separator in doc window.

This PR adds some specialized logic to handle this, tested for lua_ls and rust analyzer (lsp server won't return separator), work fine for now.

Before:

  • lua_ls (would return --- for function doc)
    image

  • rust analyzer
    image

After:

  • lua_ls (would return --- for function doc)
    image

  • rust analyzer (works like before)
    image

Some LSP servers like lua_ls would return `---` for function doc,
so the manually added separator would make two separator in doc window.
@tim3nd
Copy link
Contributor Author

tim3nd commented Dec 5, 2024

Update:
Found some outdated highlight groups in README, already updated for now. Maybe we can merge it together if don't mind :)

@Saghen Saghen merged commit fc12fa9 into Saghen:main Dec 5, 2024
@Saghen
Copy link
Owner

Saghen commented Dec 5, 2024

Thanks again!

@tim3nd tim3nd deleted the fix-render_dup_separator branch December 16, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants