implement new behavior for autocompletion menu, toggle option to require keypress for showing suggestions. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ire keypress for showing suggestions.
|
This sounds like an awesome addition, which I think would solve #52 |
|
Based on the #52 code example, the plugin will be partially disabled for the specific file type that the user configures; the PR is more general, it is meant to disable the whole autocompletion window and trigger it on default or user configure keybindings |
|
For my use-case I think this PR would be even better. I don't really want to have the behavior different on a per file type basis, rather turn of autocompletion at all since I hate things that pop up automagically while I'm typing. I want to control the behavior using a keymap at all times :) But that's me :) |
|
Thank you! |
|
Sorry for the messy code :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new
auto_showconfig for the autocompletion menu. It's set totrueby default, so nothing has changed. If we set it tofalse,then we need to press default or user-set keymaps to show the menu.