Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version that supports jruby #29

Open
OpenCoderX opened this issue Apr 17, 2021 · 4 comments
Open

New version that supports jruby #29

OpenCoderX opened this issue Apr 17, 2021 · 4 comments

Comments

@OpenCoderX
Copy link

I notice there was a recent pull request that added jruby support, can we have a new release with these changes?

@SamSaffron
Copy link
Owner

I need some help from jruby people here, are we meant to put this .jar file in our gemspec? this means that non jruby platforms will now get jruby code? Do we need to publish 2 gems here?

@zw963
Copy link

zw963 commented May 24, 2021

I create a new gem, name only_blank, it depends on this gem.

and i found this gem build not successful when add ruby-head into .travis.yml.

so, our rubygems released version still not include those java code, right?

https://travis-ci.com/github/zw963/only_blank/jobs/507495695

@headius
Copy link
Contributor

headius commented Nov 23, 2021

Sorry, it seems I never saw this issue.

The typical way to distribute this would be to build and package a jar and release a -java platform gem. No Java code would ship in the CRuby version and no extension-building would happen in the JRuby version. A recent example would be the digest gem which added JRuby support.

@enebo
Copy link
Contributor

enebo commented Dec 2, 2021

@SamSaffron I opened #31 to address this including a bonus optimization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants