Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless try-catch statement in command menu parsing code #64

Closed
SamVanheer opened this issue Nov 18, 2021 · 0 comments
Closed

Remove useless try-catch statement in command menu parsing code #64

SamVanheer opened this issue Nov 18, 2021 · 0 comments
Assignees
@SamVanheer
Labels
enhancement New feature or request

Comments

@SamVanheer
Copy link
Collaborator

There is a try-catch statement in the command menu parsing code that is completely useless. No exception of type CException exists, the exception is caught incorrectly (by non-const pointer instead of const reference), and nothing will throw the exception.

Remove this statement.
@SamVanheer SamVanheer added the enhancement New feature or request label Nov 18, 2021
@SamVanheer SamVanheer self-assigned this Nov 18, 2021
LogicAndTrick pushed a commit to LogicAndTrick/halflife-updated that referenced this issue Dec 26, 2021
@SamVanheer @LogicAndTrick
Remove useless try-catch statement in command menu parsing code
c146121 
Resolves twhl-community#64

(cherry picked from commit c36c919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamVanheer SamVanheer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SamVanheer