Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csv-file-validations): Csv File Validations in CsvToDatabseConfiguration #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SamraHanifCareem
Copy link
Owner

@SamraHanifCareem SamraHanifCareem commented Oct 30, 2022

SUMMARY
Adding CSV File Validations such as:

  • Max File Size
  • Rows to Read

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-01-04 at 3 18 52 PM

TESTING INSTRUCTIONS

  • Configure the following keys in config.py according to the requirements:
    1. CSV_MAX_SIZES 
      
    2. CSV_MAX_ROWS 
      
    3. CSV_MIN_ROWS
      
  • Route to Databases Screen
  • Upload CSV File

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required config changes : CSV_MAX_SIZES, CSV_MAX_ROWS, CSV_MIN_ROWS
  • Changes UI
  • Includes DB Migration (follow approval process in [SIP-59] Proposal for Database migration standards apache/superset#13351)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@SamraHanifCareem SamraHanifCareem changed the title feat: File Size Validation along with max and min rows to read added feat(csv-file-validations): Csv File Validations in CsvToDatabseConfiguration Jan 4, 2023
@SamraHanifCareem SamraHanifCareem added the enhancement New feature or request label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant