Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wrap Text Support for List View #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SamraHanifCareem
Copy link
Owner

@SamraHanifCareem SamraHanifCareem commented Mar 9, 2023

SUMMARY

  • Wrapping text inside list view columns

BEFORE SCREENSHOTS OR ANIMATED GIF
BeforeWrap

AFTER SCREENSHOTS OR ANIMATED GIF
AfterWrap

TESTING INSTRUCTIONS

  • Route to any screen that contains list view. For instance, Saved Queries
  • Add columnsForWrapText={['col1 header','col2 header,...]}. in ListView as mentioned in the figure below:
    WrapUsage
  • Check for the wrapped text of the defined columns on the respective screen.

ADDITIONAL INFORMATION

  • Changes In List View: superset-frontend/src/components/ListView/ListView.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant