Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce _substitute_pixel to simplify everything #78

Merged
merged 5 commits into from
Apr 29, 2022

Conversation

Saransh-cpp
Copy link
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • Package installs: julia> ]dev .
  • All tests pass: julia> ]test ChaoticEncryption
  • The documentation builds: $ cd docs and then $ julia make.jl

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Acknowledgements

This Pull Request template was taken from the excellent PyBaMM repository.

@Saransh-cpp Saransh-cpp added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 29, 2022
@github-actions
Copy link
Contributor

Once the build has completed, you can preview any updated documentation at this URL: https://saransh-cpp.github.io/ChaoticEncryption.jl/previews/PR78/ in ~5 minutes

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #78 (248f0d5) into master (8f6311c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         3    -1     
  Lines           60        51    -9     
=========================================
- Hits            60        51    -9     
Impacted Files Coverage Δ
src/substitution.jl 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Saransh-cpp Saransh-cpp merged commit d9aeda3 into master Apr 29, 2022
@Saransh-cpp Saransh-cpp deleted the simplify-speed branch April 29, 2022 16:00
@Saransh-cpp Saransh-cpp mentioned this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant