Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walletnotify.sh: don't check other wallets #310

Open
Kexkey opened this issue Oct 8, 2023 · 2 comments
Open

walletnotify.sh: don't check other wallets #310

Kexkey opened this issue Oct 8, 2023 · 2 comments
Assignees

Comments

@Kexkey
Copy link
Collaborator

Kexkey commented Oct 8, 2023

  for wallet in $(bitcoin-cli listwallets | tr -d ,\")
  do

We should only process transactions from Cyphernode's wallets (spending, watching), not every wallet current loaded in the Bitcoin Node. The node could be used for other stuff beside Cyphernode's features.

@Kexkey
Copy link
Collaborator Author

Kexkey commented Oct 8, 2023

Let's add %w to the bitcoin.conf's walletnotify line so we can skip processing the tx when it's not part of cyphernode wallet.

@phillamy
Copy link
Contributor

So we process Tx in those three wallets - matching the names :

watching01.dat
xpubwatching01.dat
spending01.dat

I remember we need to change the mosquitto_pub call also since it does not support multiple topics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants