From 9ecf0629baf90dc05c627bd30c7675c4e4361ed3 Mon Sep 17 00:00:00 2001 From: Myroslav Date: Sun, 17 Sep 2023 22:49:51 +0200 Subject: [PATCH] Append Typescript to npmDevDependencies instead of npmDependencies. (#525) --- .../scalablytyped/converter/internal/ScalaJsBundlerHack.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbt-converter/src/main/scala/org/scalablytyped/converter/internal/ScalaJsBundlerHack.scala b/sbt-converter/src/main/scala/org/scalablytyped/converter/internal/ScalaJsBundlerHack.scala index 6910bbc759..25f84cd487 100644 --- a/sbt-converter/src/main/scala/org/scalablytyped/converter/internal/ScalaJsBundlerHack.scala +++ b/sbt-converter/src/main/scala/org/scalablytyped/converter/internal/ScalaJsBundlerHack.scala @@ -19,7 +19,7 @@ object ScalaJsBundlerHack { val adaptScalaJSBundlerPackageJson: Def.Setting[_] = { Compile / scalaJSBundlerPackageJson := { - val deps = (Compile / npmDependencies).value + val deps = (Compile / npmDevDependencies).value /* Make sure we always include typescript for the stdlib if it wasnt already added */ val withTypescript: Seq[(String, String)] = if (deps.exists { case (lib, _) => lib == "typescript" }) deps @@ -27,8 +27,8 @@ object ScalaJsBundlerHack { PackageJsonTasks.writePackageJson( (Compile / npmUpdate / crossTarget).value, + (Compile / npmDependencies).value, withTypescript, - (Compile / npmDevDependencies).value, (Compile / npmResolutions).value, (Compile / additionalNpmConfig).value, fullClasspath = Nil, // hack here