Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/271/issue with starting the service since graceful udate #273

Merged

Conversation

sc-zenokerr
Copy link
Contributor

@sc-zenokerr sc-zenokerr commented Aug 1, 2024

Fixes #271
Related to Scalingo/go-utils#944
Related to STORY-828

…-service-since-graceful-udate

# Conflicts:
#	go.mod
#	go.sum
#	vendor/github.com/Scalingo/go-utils/graceful/CHANGELOG.md
#	vendor/modules.txt
Related to Scalingo/go-utils#944

Finalise merge of master
Copy link

@sc-zenokerr sc-zenokerr marked this pull request as ready for review August 14, 2024 08:42
@sc-zenokerr sc-zenokerr requested review from EtienneM and curzolapierre and removed request for curzolapierre and EtienneM August 16, 2024 05:59
Copy link
Contributor

@SCedricThomas SCedricThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

cmd/sand-agent/sand-agent.go Outdated Show resolved Hide resolved
Co-authored-by: Cédric Thomas <cedric.thomas@scalingo.com>
Copy link
Member

@Soulou Soulou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with success

@sc-zenokerr sc-zenokerr merged commit 0b9a003 into master Aug 22, 2024
2 checks passed
@sc-zenokerr sc-zenokerr deleted the fix/271/Issue-with-starting-the-service-since-graceful-udate branch August 22, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with starting the service since go-utils/graceful update
3 participants