Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong positioning of a VideoNode #217

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Fixed wrong positioning of a VideoNode #217

merged 2 commits into from
Dec 6, 2021

Conversation

RGregat
Copy link
Contributor

@RGregat RGregat commented Nov 29, 2021

  • The VideoNode is now centered and above a ParentNode.

@RGregat
Fixed wrong positioning of a VideoNode
277e2a7 
* The VideoNode is now centered and above a ParentNode.
@RGregat RGregat mentioned this pull request Nov 29, 2021
Closed
@ThomasGorisse
Copy link
Collaborator

ThomasGorisse commented Dec 2, 2021 •
edited
Loading

Did you try the AugmentedImage Video sample and Video node sample?
I don't remember if we override the rectangle position in it.

@RGregat
Added a new flag to enable a look to camera feature.
fad43e8 
* With the function call `setRotateAlwaysToCamera(boolean
rotateAlwaysToCamera)`, the VideoNode will always look to the Camera
(the user).
* The best effect can be achieved with a Video shown on a Plane. It is
not very practical with ChromaKey Videos.
@RGregat
Copy link
Contributor Author

RGregat commented Dec 4, 2021

The issue was inside of the Plane creation in the VideoNode class. And only for the "not restricted" VideoNode. The Vertical subclass had already the correct implementation. The AugmentedImage Sample was not affected because it doesn't use a VideoNode.
I added a small flag for the VideoNode to activate a point to camera rotation videoNode.setRotateAlwaysToCamera(true);. I think that is in certain situations quite handy.

@ThomasGorisse ThomasGorisse merged commit 2386c77 into master Dec 6, 2021
@ThomasGorisse ThomasGorisse deleted the fix/video_node_positioning branch December 6, 2021 08:18
ThomasGorisse added a commit to SceneView/sceneview-android that referenced this pull request Feb 25, 2022
@ThomasGorisse
Fixed wrong positioning of a VideoNode (SceneView/sceneform-android#217)
c7d482d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasGorisse ThomasGorisse Awaiting requested review from ThomasGorisse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RGregat @ThomasGorisse