-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor read_dist() #13
Comments
@NLesniak I wonder if |
@kelly-sovacool do you think we should rename this and have a specific function for each or add the ability to read different input types to this function? |
@NLesniak perhaps both? For now maybe we should rename this one to something phylip-specific. If we want/need to add support for other file types, we would add those as functions following a similar naming scheme. Potentially then |
Pat's code to read mothur's lower triangular distance file as a matrix: https://github.com/riffomonas/distances/blob/f5cb11b7d8c5a900249c5e676269699411f0092a/code/read_matrix.R |
read_dist()
should check whether the file provided is a lower triangular distance matrix, a square matrix, or not a valid format.Details on phylip-formatted distance matrices: https://mothur.org/wiki/phylip-formatted_distance_matrix/#:~:text=The%20basic%20format%20of%20a,sequence%20to%20the%20other%20sequences.
Note:
phyloseq::import_mothur_dist()
exists, but we should have our own version because:The text was updated successfully, but these errors were encountered: