Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(*): update the name from anchor.fm to spotify #127

Merged
merged 7 commits into from
Dec 16, 2024
Merged

docs(*): update the name from anchor.fm to spotify #127

merged 7 commits into from
Dec 16, 2024

Conversation

Wabri
Copy link
Member

@Wabri Wabri commented Sep 30, 2024

Closes #126

@Wabri Wabri self-assigned this Sep 30, 2024
TheJoin95
TheJoin95 reviewed Sep 30, 2024
View reviewed changes
src/spotify-pupeteer/index.js Outdated Show resolved Hide resolved
src/spotify-pupeteer/index.js Outdated Show resolved Hide resolved
src/spotify-pupeteer/index.js Outdated Show resolved Hide resolved
@TheJoin95
Copy link
Member

@Wabri please update & rebase so we can publish a new release

@Wabri Wabri marked this pull request as draft October 21, 2024 12:34
@matevskial
Copy link
Contributor

Please rename folder spotify-pupeteer to spotify-puppeteer. I've made a typo when it was named anchorfm-pupeteer

@Wabri Wabri marked this pull request as ready for review November 17, 2024 12:47
@Wabri
Copy link
Member Author

Wabri commented Nov 17, 2024

Sorry for the late of the updates, but I was working on other things 🙏

I resolve all the requested and also fix other typo that I found for puppeteer!

TheJoin95
TheJoin95 previously approved these changes Nov 17, 2024
View reviewed changes
@Wabri Wabri requested a review from matevskial November 17, 2024 16:05
@TheJoin95
Copy link
Member

@matevskial did you had the chance to have a look at this?

@matevskial
Copy link
Contributor

Not yet, I would recommend @Wabri to rebase these changes to main after I merge my branch. I will merge my branch after I do fix to make y2s work again.

@Wabri
Copy link
Member Author

Wabri commented Nov 26, 2024

I'll move this as a draft until your branch is not merged.

Blocked by #131

@Wabri Wabri marked this pull request as draft November 26, 2024 08:14
@dav1403
Copy link

dav1403 commented Dec 4, 2024

@matevskial merging your branch is making y2s working again?

@matevskial
Copy link
Contributor

@matevskial merging your branch is making y2s working again?

You are correct.

@TheJoin95 TheJoin95 marked this pull request as ready for review December 6, 2024 15:10
@TheJoin95
Copy link
Member

please rebase

@Wabri Wabri requested a review from TheJoin95 December 9, 2024 15:57
@Wabri
Copy link
Member Author

Wabri commented Dec 9, 2024

Done

@Wabri Wabri merged commit 62ee5b5 into Schroedinger-Hat:main Dec 16, 2024
@Wabri Wabri deleted the docs/126 branch December 16, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matevskial matevskial matevskial approved these changes

@TheJoin95 TheJoin95 TheJoin95 approved these changes

@abe-101 abe-101 Awaiting requested review from abe-101

Assignees

@Wabri Wabri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we rename the project?
4 participants
@Wabri @TheJoin95 @matevskial @dav1403