fix: use change event instead of keyup for node name change #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a few issues: - "keyup" is not triggered when copy-pasting. So if the user right clicks and pastes a new value, the name would not get updated. - "keyup" triggers each time a character is typed in the input field. This results in a lot of operations on each keypress. - No need to set this.nodeProperties.nodeBetriebspunktName nor this.nodeProperties.nodeBetriebspunktFullName on keyup: this is already done automatically by [ngModel]. Note that we do loose a bit of functionality with this patch: the diagrams and sidebar headings aren't updated in real-time as the user types anymore.
|
Great idea 👍 |
louisgreiner
approved these changes
Aug 19, 2024
emersion
added a commit
to OpenRailAssociation/osrd
that referenced
this pull request
Aug 19, 2024
The current approach doesn't work when editing two nodes in succession: edit node A and before 2s elapse edit node B. The debounce will only invoke the callback for node B, dropping changes for node A. Moreover, switching to the micro tab will not immediately reflect changes. Instead, NGE has been patched [1] to only trigger the node update event once the input field is unfocused. [1]: SchweizerischeBundesbahnen/netzgrafik-editor-frontend#248
emersion
added a commit
to OpenRailAssociation/osrd
that referenced
this pull request
Aug 19, 2024
The current approach doesn't work when editing two nodes in succession: edit node A and before 2s elapse edit node B. The debounce will only invoke the callback for node B, dropping changes for node A. Moreover, switching to the micro tab will not immediately reflect changes. Instead, NGE has been patched [1] to only trigger the node update event once the input field is unfocused. [1]: SchweizerischeBundesbahnen/netzgrafik-editor-frontend#248
github-merge-queue bot
pushed a commit
to OpenRailAssociation/osrd
that referenced
this pull request
Aug 20, 2024
The current approach doesn't work when editing two nodes in succession: edit node A and before 2s elapse edit node B. The debounce will only invoke the callback for node B, dropping changes for node A. Moreover, switching to the micro tab will not immediately reflect changes. Instead, NGE has been patched [1] to only trigger the node update event once the input field is unfocused. [1]: SchweizerischeBundesbahnen/netzgrafik-editor-frontend#248
Uriel-Sautron
pushed a commit
to osrd-project/netzgrafik-editor-frontend
that referenced
this pull request
Sep 19, 2024
…rischeBundesbahnen#248) Fixes a few issues: - "keyup" is not triggered when copy-pasting. So if the user right clicks and pastes a new value, the name would not get updated. - "keyup" triggers each time a character is typed in the input field. This results in a lot of operations on each keypress. - No need to set this.nodeProperties.nodeBetriebspunktName nor this.nodeProperties.nodeBetriebspunktFullName on keyup: this is already done automatically by [ngModel]. Note that we do loose a bit of functionality with this patch: the diagrams and sidebar headings aren't updated in real-time as the user types anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues:
Note that we do loose a bit of functionality with this patch: the diagrams and sidebar headings aren't updated in real-time as the user types anymore. If this is deemed important functionality, we could use
(ngModelChange)instead.