Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 334 bug archived read mode allows to move nodes but not persisted #336

Conversation

aiAdrian
Copy link
Collaborator

@aiAdrian aiAdrian commented Nov 5, 2024

Description

The rendering performance is a key feature in the Netzgrafik-Editor. To achieve a redrawing of only changing objects requires a speical change detector. This was missing the change of read/write mode.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

@aiAdrian aiAdrian linked an issue Nov 5, 2024 that may be closed by this pull request
3 tasks
@aiAdrian aiAdrian requested a review from louisgreiner November 5, 2024 16:41
Copy link
Collaborator

@louisgreiner louisgreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, but we still have the mouse cursor that is wrong (even tho it can't move the node):

Enregistrement.de.l.ecran.2024-11-06.104212.mp4

…over when readonly was not correctly activated
@louisgreiner louisgreiner self-requested a review November 6, 2024 12:43
Copy link
Collaborator

@louisgreiner louisgreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfectly !

@aiAdrian aiAdrian merged commit 6275ae1 into main Nov 6, 2024
7 checks passed
@aiAdrian aiAdrian deleted the 334-bug-archived-read-mode-allows-to-move-nodes-but-not-persisted branch November 6, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Archived (read-mode) allows to move nodes (but not persisted)
2 participants