feat: introduce standalone mode #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
commented
Jun 27, 2024
Comment on lines
+66
to
+71
| getSidebarContainerStyle(): string { | ||
| if (this.disableBackend) { | ||
| return "top: 53px;"; | ||
| } | ||
| return "top: 85px;"; | ||
| } |
There was a problem hiding this comment.
Hm, I wonder if we should instead add a disable-backend CSS class, and use that to guard the CSS rules, instead of this?
emersion
commented
Jun 27, 2024
| @@ -48,13 +52,24 @@ export class NetzgrafikApplicationComponent { | |||
| .subscribe((params) => { | |||
| uiInteractionService.setEditorMode(EditorMode.NetzgrafikEditing); | |||
| uiInteractionService.showNetzgrafik(); | |||
| versionControlService.load(params.getVariantId(), true); | |||
| try { | |||
There was a problem hiding this comment.
Is there a reason why this is a try/catch instead of a if (disableBackend)?
emersion
commented
Jun 27, 2024
emersion
commented
Jun 27, 2024
Comment on lines
+74
to
+79
| getLayoutContentStyle(): string { | ||
| if (environment.disableBackend) { | ||
| return "height: 100%;"; | ||
| } | ||
| return ""; | ||
| } |
There was a problem hiding this comment.
Ditto: could use a CSS class here instead.
emersion
commented
Jun 27, 2024
| authConfig: AuthConfig; | ||
| backendUrl?: string; | ||
| authConfig?: AuthConfig; | ||
| disableBackend: boolean; |
There was a problem hiding this comment.
We've been wondering whether it would make more sense to drop the disableBackend field, and instead make it so a null backendUrl means that the backend is disabled. Personally I think that'd make sense since backendUrl is nullable.
emersion
force-pushed
the
standalone-ep-1
branch
from
7977c4a to
29ff459
Compare
Co-authored-by: adrian_egli <adrian.egli@gmail.com> Co-authored-by: Simon Ser <contact@emersion.fr>
Co-authored-by: Louis Greiner <greiner.louis@gmail.com>
emersion
force-pushed
the
standalone-ep-1
branch
from
29ff459 to
6b50c72
Compare
louisgreiner
approved these changes
Jun 27, 2024
…doesn't work correctly. This fix resolves the issue.
aiAdrian
approved these changes
Jul 2, 2024
|
Thank you! |
louisgreiner
added a commit
that referenced
this pull request
Jul 9, 2024
* feat: introduce standalone mode Co-authored-by: adrian_egli <adrian.egli@gmail.com> Co-authored-by: Simon Ser <contact@emersion.fr> * feat: register as a custom element Co-authored-by: Louis Greiner <greiner.louis@gmail.com> * fix: easy return * small fix - the use of ng-container embeded in the sbb-icon-sidebare doesn't work correctly. This fix resolves the issue. --------- Co-authored-by: Louis Greiner <greiner.louis@gmail.com> Co-authored-by: adrian_egli <adrian.egli@gmail.com>
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first part of #158, cleaned-up and rebased.
This is missing inputs/outputs for
AppComponent: that work will come as a second follow-up PR once this one is merged.The normal behavior of the application remains the same (
ngsscbuildhas not been modified, only scripts to trigger newstandaloneenvironment have been added)Checklist
documentation/