Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish package on NPM #172

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

emersion
Copy link
Collaborator

@emersion emersion commented Jul 9, 2024

Description

This is the last part of #158.

Add two new CI tasks: one to build the standalone variant on push, and another one to publish an NPM package on release.

The latter requires setting up a NPM_TOKEN secret in the GitHub repository settings.

All dependencies are removed before publication because the published package is completely standalone: all of the dependencies are bundled in dist/.

Add the "repository" field in package.json: it's a requirement for the npm publish --provenance flag.

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

Add two new CI tasks: one to build the standalone variant on push,
and another one to publish an NPM package on release.

The latter requires setting up a `NPM_TOKEN` secret in the GitHub
repository settings.

All dependencies are removed before publication because the
published package is completely standalone: all of the dependencies
are bundled in `dist/`.

Add the "repository" field in package.json: it's a requirement for
the npm publish --provenance flag.
@emersion emersion requested a review from aiAdrian as a code owner July 9, 2024 07:14
@emersion emersion requested a review from louisgreiner July 9, 2024 07:14
Copy link
Collaborator

@aiAdrian aiAdrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aiAdrian aiAdrian merged commit 1692d55 into SchweizerischeBundesbahnen:main Jul 9, 2024
6 checks passed
@emersion emersion deleted the standalone-ep-3 branch July 9, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants