fix: disable notes in filter sidebar in standalone mode #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes are disabled in standalone mode.
louisgreiner
approved these changes
Aug 5, 2024
…splayed in the filter. To keep everything consistent, these labels will also be deactivated in the filter and hidden in the note-edit dialog.
|
This change looks good. But i added : 278dc95 |
|
Tested, lgtm |
This was referenced Aug 6, 2024
Uriel-Sautron
pushed a commit
to osrd-project/netzgrafik-editor-frontend
that referenced
this pull request
Sep 19, 2024
…heBundesbahnen#211) * fix: disable notes in filter sidebar in standalone mode Notes are disabled in standalone mode. * If the backend is turned off, the notes - labels will no longer be displayed in the filter. To keep everything consistent, these labels will also be deactivated in the filter and hidden in the note-edit dialog. --------- Co-authored-by: adrian_egli <adrian.egli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes are disabled in standalone mode.