Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

236 feature request security updates #238

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

aiAdrian
Copy link
Collaborator

@aiAdrian aiAdrian commented Aug 12, 2024

Description

The Dependabot reports security problems. The packages used should therefore be kept to a minimum and those installed should also be up to date in order to minimise the risk of security problems (virtualities).

Issues

Dependabot - alerts

Checklist

  • This PR contains a description of the changes I'm making
  • I've read the Contribution Guidelines
  • I've added tests for changes or features I've introduced
  • I documented any high-level concepts I'm introducing in documentation/
  • CI is currently green and this is ready for review

npx npm-check-updates -u -t patch
npm ci
@aiAdrian aiAdrian linked an issue Aug 12, 2024 that may be closed by this pull request
3 tasks
npx npm-check-updates -u -t patch
npm ci
@aiAdrian aiAdrian requested a review from emersion August 12, 2024 20:57
Copy link
Collaborator

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that most of the alerts sound like false alarms: they are about server-side stuff we don't care about since this is the frontend, or devDependencies which shouldn't matter since they're only run by developers.

@aiAdrian aiAdrian merged commit 5760de2 into main Aug 13, 2024
6 checks passed
@aiAdrian aiAdrian deleted the 236-feature-request-security-updates branch August 13, 2024 07:50
Uriel-Sautron pushed a commit to osrd-project/netzgrafik-editor-frontend that referenced this pull request Sep 19, 2024
* removed unrequired packages

* All patches updates (npx npm-check-updates -u -t patch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Security updates
2 participants