Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Fix Manta output #584

Merged
merged 9 commits into from
May 17, 2018
Merged

Fix Manta output #584

merged 9 commits into from
May 17, 2018

Conversation

maxulysse
Copy link
Member

Some output was not there anymore due to #579

@maxulysse
Copy link
Member Author

We had $filename as an output, and it should have been filename.
I also took the opportunity to reduce PublishDir directive.

@maxulysse
Copy link
Member Author

Do not merge, yet, there is still some issues to figure out...

@maxulysse
Copy link
Member Author

OK, so in fact as long as a file is an output, it will be in the work directories.

So I present you this final fix to our problem.

The idea was to use the join operator to phase the bams/bais and the RunManta output (small) without feeding these into RunManta.

In order to do that I choose to reorder the items in our input/output.
Instead of: idPatient, idSampleNormal, bamNormal, baiNormal, idSampleTumor, bamTumor, baiTumor
we now have: idPatient, idSampleNormal, idSampleTumor, bamNormal, baiNormal, bamTumor, baiTumor

I think we have some other process that have an output that will be in the work directory when using scratch, so I'll need to fix that as well.

I do think that we're using the now depreciated phase operator, so it'll be fixed as well.

@maxulysse maxulysse requested a review from szilvajuhos May 8, 2018 15:08
@maxulysse
Copy link
Member Author

Finally remapping the channels before joining so we don't touch other parts of the script.

So finally what we're now doing is not using bam as an output in Manta, but joining a channel containing the bam to the StrelkaBP output.

I tested it, and it seems to be working ;-)

@szilvajuhos szilvajuhos merged commit 64184db into SciLifeLab:master May 17, 2018
@maxulysse maxulysse deleted the Documentation branch May 17, 2018 07:13
@maxulysse maxulysse mentioned this pull request Jun 13, 2018
jherrero referenced this pull request in UCL-BLIC/Sarek_v2.2.1 Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants