Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Code polishing #597

Merged
merged 5 commits into from
Jun 14, 2018
Merged

Code polishing #597

merged 5 commits into from
Jun 14, 2018

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Jun 12, 2018

Move existing functions from scripts to SarekUtils library:

  • checkFileExtension
  • checkParameterExistence
  • checkParameterList
  • checkReferenceMap
  • checkRefExistence
  • extractBams
  • extractGenders
  • returnFile
  • returnStatus
  • returnTSV

Modify function extractBams:

  • take an extra parameter (somatic or germline) to return Channel with or without gender respectively

Add new function to SarekUtils:

  • sarek_ascii() for fancy Ascii Art

Replace depreciated operator phase by join:

  • for Channels bamsForHC and recalTables in germlineVC.nf
  • for Channels duplicatesRealign and intervals in main.nf

Remove data footprint (a bam file was stored twice in the work directory for no reason like #584):

  • removed files bam and bai from Process CreateRecalibrationTable
  • duplicate Channel realignedBam to realignedBamToJoin
  • use operator join for Channels realignedBamToJoin and recalibrationTable

@maxulysse maxulysse requested a review from szilvajuhos June 12, 2018 14:34
Copy link
Collaborator

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I understand :) It is nice to see groovy utils growing.

@szilvajuhos szilvajuhos merged commit e31bb15 into SciLifeLab:master Jun 14, 2018
@maxulysse maxulysse deleted the codePolishing branch June 14, 2018 10:11
jherrero referenced this pull request in UCL-BLIC/Sarek_v2.2.1 Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants