Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix formatting failures #653

Closed
isaacsas opened this issue Jul 16, 2023 · 1 comment
Closed

fix formatting failures #653

isaacsas opened this issue Jul 16, 2023 · 1 comment

Comments

@isaacsas
Copy link
Member

Once domluna/JuliaFormatter.jl#741 is settled and a new style is released we need to reformat the repo. It will likely impact almost every file. As that PR points out the most recent style update has issues that make reading functions more difficult so we can just hold off until the issue is settled.

I suggest we just ignore formatting failures on CI until an appropriate style update is made and released.

@isaacsas
Copy link
Member Author

Alternatively one can format using v1.0.32 of JuliaFormatter, which CI is now fixed to use. That should avoid reformatting the entire repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant