-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding events macro to reaction network DSL #694
Comments
I think this looks good. Can't one have multiple events within the begin/end blocks? Or by "different events" do you mean if you want to change the events in an already created system? The general design, which we admittedly don't always adhere to, is that systems should be immutable. So if you want to change something in a system you need to generate a new system with the desired properties. Even from the current symbolic interface, where events are created as kwargs to But maybe I've misunderstood your point? |
Also, one can always create a |
now works on master |
One possible way of doing this is the following:
However, I think by having the macro inside
@reaction_network
you loose some flexibility. For example, if you wanted to use rn with different events. It could also be argued that conceptually a reaction network is how the species interact with each other but, the events, being external added boundary conditions, merging the two would not be a good idea.The text was updated successfully, but these errors were encountered: