-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential issues with isequivalent
function
#839
Comments
issetequal
function
issetequal
functionisequivalent
function
Probably we need to make a list at some point of everything that needs updating when adding new fields to |
Yeah, I think I entirely forgot about this when I added e.g. the |
A checklist of what functions should be updated in the comments before the ReactionSystem structure def would probably help with this. |
Maybe something we can add to the dev docs (once we write those)? Just as a natural place to keep that. Alternatively we can just create an internal .txt doc with stuff like that (that we don't necessarily display in the docs, but link to). |
Why isn't this |
We dispatch |
Either should be fine. |
I don't really know exactly what is the exact intention of this function, but some notes:
complete
be checked?issetequal
is used. Does this actually useisequivalent
though? If not, shouldn'tisequivalent
somehow be called on the subsystems?The text was updated successfully, but these errors were encountered: