Skip to content

Commit

Permalink
fix: update minimum compats
Browse files Browse the repository at this point in the history
  • Loading branch information
avik-pal committed Sep 27, 2024
1 parent cd67a51 commit 25edaa4
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 14 deletions.
1 change: 0 additions & 1 deletion .github/workflows/Downgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
with:
version: ${{ matrix.version }}
- uses: julia-actions/julia-downgrade-compat@v1
# if: ${{ matrix.version == '1.6' }}
with:
skip: Pkg,TOML
- uses: julia-actions/julia-buildpkg@v1
Expand Down
18 changes: 9 additions & 9 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,25 +22,25 @@ Aqua = "0.8"
ConcreteStructs = "0.2.3"
DataInterpolations = "4.6, 5, 6"
DataStructures = "0.18.13"
DiffEqBase = "6.154"
DiffEqBase = "6.155.3"
DifferentiationInterface = "0.6.1"
ForwardDiff = "0.10.36"
Functors = "0.4"
LinearAlgebra = "1.10"
Markdown = "1.10"
NonlinearSolve = "3.7.2"
ODEProblemLibrary = "0.1.5"
NonlinearSolve = "3.14"
ODEProblemLibrary = "0.1.8"
OrdinaryDiffEq = "6.88"
QuadGK = "2.9"
RecipesBase = "1.3.4"
RecursiveArrayTools = "3.9"
SciMLBase = "2.26"
SciMLSensitivity = "7.56"
StaticArrays = "1.8"
RecursiveArrayTools = "3.27"
SciMLBase = "2.54"
SciMLSensitivity = "7.68"
StaticArrays = "1.9.7"
StaticArraysCore = "1.4"
Sundials = "4.19.2"
Test = "1"
Tracker = "0.2.26"
Test = "1.10"
Tracker = "0.2.35"
Zygote = "0.6.69"
julia = "1.10"

Expand Down
8 changes: 4 additions & 4 deletions src/manifold.jl
Original file line number Diff line number Diff line change
Expand Up @@ -418,19 +418,19 @@ end
function safe_factorize!(A::AbstractMatrix)
if issquare(A)
fact = LinearAlgebra.cholesky(A; check = false)
fact_sucessful(fact) && return fact
fact_successful(fact) && return fact
elseif size(A, 1) > size(A, 2)
fact = LinearAlgebra.qr(A)
fact_sucessful(fact) && return fact
fact_successful(fact) && return fact
end
return LinearAlgebra.qr!(A, LinearAlgebra.ColumnNorm())
end

function fact_sucessful(F::LinearAlgebra.QRCompactWY)
function fact_successful(F::LinearAlgebra.QRCompactWY)
m, n = size(F)
U = view(F.factors, 1:min(m, n), 1:n)
return all(!iszero, Iterators.reverse(@view U[diagind(U)]))
end
function fact_sucessful(F::FT) where {FT}
function fact_successful(F::FT) where {FT}
return hasmethod(LinearAlgebra.issuccess, (FT,)) ? LinearAlgebra.issuccess(F) : true
end

0 comments on commit 25edaa4

Please sign in to comment.